[Webkit-unassigned] [Bug 40139] [GTK] Widgets do not support CSS transformations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40139





--- Comment #6 from Alejandro G. Castro <alex at igalia.com>  2010-10-19 05:22:36 PST ---
(From update of attachment 71083)
Patch looks like a very good idea :).

View in context: https://bugs.webkit.org/attachment.cgi?id=71083&action=review

> LayoutTests/ChangeLog:14
> +        * platform/gtk/fast/forms/slider-transformed-expected.txt: Added.

I think this file is not in the patch.

> WebCore/platform/gtk/RenderThemeGtk.cpp:169
> +    , m_themeParts(g_new0(GtkThemeParts, 1))
> +#ifdef GTK_API_VERSION_2
> +    , m_themePartsHaveRGBAColormap(true)
> +#endif
>  {
> -    if (!mozGtkRefCount) {
> -        moz_gtk_init();
>  
> -        // Use the theme parts for the default drawable.
> -        moz_gtk_use_theme_parts(partsForDrawable(0));
> +#ifdef GTK_API_VERSION_2
> +    GdkColormap* colormap = gdk_screen_get_rgba_colormap(gdk_screen_get_default());
> +    if (!colormap) {
> +        m_themePartsHaveRGBAColormap = false;
> +        colormap = gdk_screen_get_default_colormap(gdk_screen_get_default());
>      }
> +    m_themeParts->colormap = colormap;
> +#endif

I was wondering if we could move this code and m_theme attributes to the WidgetRenderingContext object or to the gtkxdrawing. In any case we could leave it for future patches.

> WebCore/platform/gtk/WidgetRenderingContextGtk2.cpp:149
> +    // The origin of the blit is the original target rectangle adjusted for any extra space.
> +    IntPoint targetOrigin(m_targetRect.x() - m_extraSpace.width(),
> +                          m_targetRect.y() - m_extraSpace.height());

I think we can use IntRect and inflate to simplify this code.

> WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp:51
>  

I needed these modifications to compile WidgetRenderingContextGtk3.cpp:


diff --git a/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp b/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
index 693c40e..bd826d9 100644
--- a/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
+++ b/WebCore/platform/gtk/WidgetRenderingContextGtk3.cpp
@@ -32,12 +32,12 @@ WidgetRenderingContext::WidgetRenderingContext(GraphicsContext* graphicsContext,
     : m_graphicsContext(graphicsContext)
     , m_targetRect(targetRect)
     , m_paintRect(targetRect)
-    , m_target(context->platformContext())
     , m_hadError(false)
+    , m_target(graphicsContext->platformContext())
 {
 }

-~WidgetRenderingContext::WidgetRenderingContext()
+WidgetRenderingContext::~WidgetRenderingContext()
 {
 }

@@ -47,4 +47,6 @@ bool WidgetRenderingContext::paintMozillaWidget(GtkThemeWidgetType type, GtkWidg
     return !m_hadError;
 }

+}
+
 #endif // !GTK_API_VERSION_2

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.