[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #34 from Gustavo Noronha (kov) <gns at gnome.org>  2010-10-19 06:55:11 PST ---
(From update of attachment 70527)
View in context: https://bugs.webkit.org/attachment.cgi?id=70527&action=review

> WebKit/gtk/webkit/webkitviewportattributes.h:85
> +WEBKIT_API void 
> +webkit_viewport_attributes_computation              (WebKitViewportAttributes* viewportAttributes, 
> +                                                     WebKitWebFrame* mainFrame, 
> +                                                     gint availableWidth,
> +                                                     gint availableHeight);

Computation is a noun, so it's a bad name for this method (which should always be verbs). Having to provide the main frame here is also a bit weird. Perhaps the viewport should have a weak reference to the view?

> WebKit/gtk/webkit/webkitwebview.h:409
> +WEBKIT_API void 
> +webkit_web_view_set_viewport_attributes         (WebKitWebView        *webView,
> +                                                 gint                 desktopWidth, 
> +                                                 gint                 deviceWidth, 
> +                                                 gint                 deviceHeight, 
> +                                                 gint                 deviceDPI);

I dislike this because it breaks the expectation that a get will return an object and a set would set the same object. I do not really understand why you would want to set these values manually. Why do we need this function?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.