[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70527|review?                     |review-
               Flag|                            |




--- Comment #33 from Martin Robinson <mrobinson at webkit.org>  2010-10-18 10:29:55 PST ---
(From update of attachment 70527)
View in context: https://bugs.webkit.org/attachment.cgi?id=70527&action=review

Great patch! The API changes look fine to me and the documentation is awesome. I have a few very small nits.

> WebKit/gtk/ChangeLog:10
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [GTK] Support for viewport meta tag
> +        https://bugs.webkit.org/show_bug.cgi?id=45443
> +
> +        This patch allows to get the viewport attributes to set the width and initial scale of the viewport
> +        used to display web content.
> +

I think this ChangeLog should be a bit bigger. This patch effectively adds viewport support to the GTK+ port, so it should probably have at least one sentence about what the viewport support does.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:116
> + * Returns the width of the #WebKitViewportAttributes in pixels.
> + *
> + * Returns: the width of the #WebKitViewportAttributes in pixels

Does this really need to be repeated for all these methods?

> WebKit/gtk/webkit/webkitviewportattributes.cpp:124
> +    g_return_val_if_fail(WEBKIT_IS_VIEWPORT_ATTRIBUTES(viewportAttributes), 0);
> +
> +    return viewportAttributes->priv->width;

I'd say remove the extra line here and in the rest of the two-line methods.

> WebKit/gtk/webkit/webkitviewportattributes.cpp:268
> +// for internal use only

New comments should be complete sentences.

> WebKit/gtk/webkit/webkitwebview.cpp:4529
> +    g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
> +
> +    webView->priv->viewportAttributes = adoptPlatformRef(webkit_viewport_attributes_new(desktopWidth, deviceWidth, deviceHeight, deviceDPI));

I'd say remove the extra line from the two line methods again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.