[Webkit-unassigned] [Bug 47879] FAIL: test_reset_results (webkitpy.layout_tests.run_webkit_tests_unittest.RebaselineTest)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47879





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2010-10-18 23:02:19 PST ---
(In reply to comment #5)
> (From update of attachment 71136 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71136&action=review
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:71
> > +# FIXME: This makes StringIO objects work with "with". Remove
> > +# when we upgrade to 2.6.
> > +class NewStringIO(StringIO.StringIO):
> > +    def __enter__(self):
> > +        return self
> > +
> > +    def __exit__(self, type, value, traceback):
> > +        pass
> 
> If this is copy/pasted from somewhere else, that's pretty strong evidence we should move it into somewhere more general.  Maybe webkitpy.common.system ?

There's nothing system-y about it. How about just webkitpy.common.newstringio ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.