[Webkit-unassigned] [Bug 47879] FAIL: test_reset_results (webkitpy.layout_tests.run_webkit_tests_unittest.RebaselineTest)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 18 23:00:26 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=47879





--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-10-18 23:00:26 PST ---
(From update of attachment 71136)
View in context: https://bugs.webkit.org/attachment.cgi?id=71136&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:71
> +# FIXME: This makes StringIO objects work with "with". Remove
> +# when we upgrade to 2.6.
> +class NewStringIO(StringIO.StringIO):
> +    def __enter__(self):
> +        return self
> +
> +    def __exit__(self, type, value, traceback):
> +        pass

If this is copy/pasted from somewhere else, that's pretty strong evidence we should move it into somewhere more general.  Maybe webkitpy.common.system ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list