[Webkit-unassigned] [Bug 47879] FAIL: test_reset_results (webkitpy.layout_tests.run_webkit_tests_unittest.RebaselineTest)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47879





--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2010-10-18 22:57:57 PST ---
(In reply to comment #2)
> (From update of attachment 71134 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71134&action=review
> 
> > WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:171
> > +        return base.Port.maybe_make_directory(self, *path)
> 
> Call-through mocks are dangerous because they can have unexpected side-effects.
>

Agreed. Hence the FIXME. If we don't have the fallthrough, all sorts of weird things will break in the meantime.

> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:71
> > +# FIXME: This makes StringIO objects work with "with". Remove
> > +# when we upgrade to 2.6.
> > +class NewStringIO(StringIO.StringIO):
> > +    def __enter__(self):
> > +        return self
> > +
> > +    def __exit__(self, type, value, traceback):
> > +        pass
> 
> This seems like a very general concept.  Is there a reason it's in this very specific file?
> 

No, in fact this was cloned from port/base_unittest.py. I would be happy to put it in webkitpy/common somewhere if you thought that was a better place for it.

> > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:306
> > +                         '--child-processes=1',
> 
> I don't understand why this is related.

It's not. I accidentally left that in from debugging the issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.