[Webkit-unassigned] [Bug 47879] FAIL: test_reset_results (webkitpy.layout_tests.run_webkit_tests_unittest.RebaselineTest)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47879





--- Comment #2 from Adam Barth <abarth at webkit.org>  2010-10-18 22:54:31 PST ---
(From update of attachment 71134)
View in context: https://bugs.webkit.org/attachment.cgi?id=71134&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:171
> +        return base.Port.maybe_make_directory(self, *path)

Call-through mocks are dangerous because they can have unexpected side-effects.

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:71
> +# FIXME: This makes StringIO objects work with "with". Remove
> +# when we upgrade to 2.6.
> +class NewStringIO(StringIO.StringIO):
> +    def __enter__(self):
> +        return self
> +
> +    def __exit__(self, type, value, traceback):
> +        pass

This seems like a very general concept.  Is there a reason it's in this very specific file?

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:306
> +                         '--child-processes=1',

I don't understand why this is related.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.