[Webkit-unassigned] [Bug 47728] Add public functions to serialize TransformOperations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47728





--- Comment #8 from Noam Rosenthal <noam.rosenthal at nokia.com>  2010-10-15 13:22:05 PST ---
(In reply to comment #7)
> (From update of attachment 70889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=70889&action=review
> 
> I'm not convinced that it's OK to serialize everything to doubles. I guess there are tokens in the serialization stream that are not visible to these methods?

Originally I thought about using Vector<char>, but then I just end up casting it to doubles (in all the cases but Translate), which doesn't look right. This seems more robust since I can deal with the actual serialization in CoreIPC::ArgumentEncoder, and just pass doubles to the WebCore::TransformOperation classes. Maybe setRawData is more suitable then serialize then?


> 
> You need to serialize m_type here too.
> 
The idea is to serialize that separately in ArgumentCoder via getOperationType - since I need that information in order to know which class to construct, and 
I don't want to duplicate its serialization for each type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.