[Webkit-unassigned] [Bug 47728] Add public functions to serialize TransformOperations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47728





--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com>  2010-10-15 13:15:49 PST ---
(From update of attachment 70889)
View in context: https://bugs.webkit.org/attachment.cgi?id=70889&action=review

I'm not convinced that it's OK to serialize everything to doubles. I guess there are tokens in the serialization stream that are not visible to these methods?

> WebCore/platform/graphics/transforms/RotateTransformOperation.cpp:103
> +void RotateTransformOperation::serialize(Vector<double> & data) const
> +{
> +    data.resize(4);
> +    data[0] = m_x;
> +    data[1] = m_y;
> +    data[2] = m_z;
> +    data[3] = m_angle;
> +}
> +

You need to serialize m_type here too.

> WebCore/platform/graphics/transforms/TransformOperation.cpp:43
> +        return ScaleTransformOperation::create(data[0], data[1], data[2], operationType);
> +        break;

No need to break after a return.

> WebCore/platform/graphics/transforms/TransformOperation.cpp:49
> +    case TRANSLATE_3D:
> +        {

Brace goes on previous line.

> WebCore/platform/graphics/transforms/TransformOperation.cpp:56
> +        }
> +        break;

Normally we put the } after the break. But the break can be removed because of the return.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.