[Webkit-unassigned] [Bug 47517] Add DelayProcessor files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47517





--- Comment #3 from Chris Rogers <crogers at google.com>  2010-10-13 11:26:39 PST ---
(From update of attachment 70494)
View in context: https://bugs.webkit.org/attachment.cgi?id=70494&action=review

Hi Chris, thanks for the review.  I'm uploading a new patch with the fixes.

>> WebCore/webaudio/DelayProcessor.h:34
>> +namespace WebCore {
> 
> don't you want an #if ENABLE(WEB_AUDIO) in the header file too?

I think it's only supposed to go into the .cpp file.  This is how the other feature enables work, like 3D_CANVAS in WebCore/html/canvas

>> WebCore/webaudio/DelayProcessor.h:45
>> +    AudioParam* delayTime() { return m_delayTime.get(); }
> 
> this should be const

FIXED

>> WebCore/webaudio/DelayProcessor.h:48
>> +    RefPtr<AudioParam> m_delayTime;
> 
> why this is protected instead of private

FIXED

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.