[Webkit-unassigned] [Bug 47517] Add DelayProcessor files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47517


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70494|review?                     |review-
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2010-10-13 00:53:15 PST ---
(From update of attachment 70494)
View in context: https://bugs.webkit.org/attachment.cgi?id=70494&action=review

> WebCore/webaudio/DelayProcessor.h:34
> +namespace WebCore {

don't you want an #if ENABLE(WEB_AUDIO) in the header file too?

> WebCore/webaudio/DelayProcessor.h:45
> +    AudioParam* delayTime() { return m_delayTime.get(); }

this should be const

> WebCore/webaudio/DelayProcessor.h:48
> +    RefPtr<AudioParam> m_delayTime;

why this is protected instead of private

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.