[Webkit-unassigned] [Bug 47432] No longer ASSERT for LayerRenderer in VideoLayerChromium destructor

Wed Oct 13 02:58:34 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47432

--- Comment #10 from Hin-Chung Lam <hclam at google.com>  2010-10-13 02:58:34 PST ---
I tried to create a new layout test for this I can't figure a way to test this without making changes to test_shell.

There are some conditions to trigger this:
1. A video is loaded and the first 2 frames are decoded.
2. Either WebMediaPlayer::repaint is not called or the repaint never reach LayerRendererChromium.

(1) is easy. (2) is hard to do, it is possible that repaint is fired but before it reaches LayerRendererChromium we destroy WebMediaPlayer, this is very time dependent and is not realistic. What is really causing this crash is that LayerRendererChromium failed to be initialized in a valid GL context, so we created a VideoLayerChromium and never associate it with a LayerRendererChromium.

I wonder if we can modify LayoutTestController to allow tests to cripple GL context initialization. Or we add a flag to run test_shell with --fail-mesa-initialization and --enable-accelerated-compositing to make sure tests don't crash.

Besides testing, instead of early return if we have a good way to check if compositor is inactive we can skip creating VideoLayerChromium, any thoughts on this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.