[Webkit-unassigned] [Bug 47432] No longer ASSERT for LayerRenderer in VideoLayerChromium destructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47432





--- Comment #9 from Hin-Chung Lam <hclam at google.com>  2010-10-13 01:32:41 PST ---
(In reply to comment #8)
> (In reply to comment #6)
> > There are already layout tests that inject a video element and then remove it from the DOM tree. 
> 
> But does this destroy the VideoLayerChromium? When I was playing around with JavaScript on my local build of Chrome (that is, not in test_shell or drt), it seemed like removing the video element from the DOM tree did not destruct the WebMediaPlayer and therefore did not destruct the VideoLayerChromium; only refreshing the page seemed to destroy the layer. I could have done something wrong though. Can you show me which test(s) will actually destroy the VideoLayerChromium? 
> 

Remove a video tag does destroy WebMediaPlayer. I tested this with test_shell.

media/controls-after-reload.html will destroy the WebMediaPlayer. And if --enable-accelerated-compositing is used VideoLayerChromium is also destroyed. So I think it's a different code path that triggers the crash.

> On the other hand, if refreshing the page is the only way to destroy the VideoLayerChromium, then I'm still not sure how to write a layout test for this even with Mesa since I'm not sure how to trigger this code path.

(In reply to comment #8)
> (In reply to comment #6)
> > There are already layout tests that inject a video element and then remove it from the DOM tree. 
> 
> But does this destroy the VideoLayerChromium? When I was playing around with JavaScript on my local build of Chrome (that is, not in test_shell or drt), it seemed like removing the video element from the DOM tree did not destruct the WebMediaPlayer and therefore did not destruct the VideoLayerChromium; only refreshing the page seemed to destroy the layer. I could have done something wrong though. Can you show me which test(s) will actually destroy the VideoLayerChromium? 
> 
> On the other hand, if refreshing the page is the only way to destroy the VideoLayerChromium, then I'm still not sure how to write a layout test for this even with Mesa since I'm not sure how to trigger this code path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.