[Webkit-unassigned] [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47070


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70377|review?                     |review-
               Flag|                            |




--- Comment #42 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-09 16:47:24 PST ---
(From update of attachment 70377)
View in context: https://bugs.webkit.org/attachment.cgi?id=70377&action=review

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:40
> +    PlatformLayerProxyQt(QWebFrame* frame, TextureMapperContentLayer* layer, QWidget* widget = 0, QGraphicsObject* graphicsObject = 0)
> +        : QObject(widget ? (QObject*)widget : (QObject*)graphicsObject)
> +        , m_widget(widget)
> +        , m_graphicsItem(graphicsObject)

I dont like this very much... it is not clear if you can have widget and graphics object at the same time and in that case, what the widget would be

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:94
> +
> +    QRect m_dirtyRect;
> +    QWidget* m_widget;
> +    QGraphicsItem* m_graphicsItem;
> +    QWebFrame* m_frame;
> +    TextureMapperContentLayer* m_layer;

Why are these public?

> WebKit/qt/WebCoreSupport/PageClientQt.cpp:428
> -    // The sceneRect is a good approximation of the size of the application, independent of the view.
> +    // The sceneRect is a good approximation of the size of the application, in dependent of the view.

This change doesn't seem right

> WebKit/qt/WebCoreSupport/PageClientQt.h:53
> +    PageClientQWidget(QWidget* v, QWebPage *p)
> +        : view(v)
> +        , page(p)

just write out things

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.