[Webkit-unassigned] [Bug 47070] [Texmap] [Qt] Texture mapper initial implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47070


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70365|review?                     |review-
               Flag|                            |




--- Comment #41 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-10-09 16:42:55 PST ---
(From update of attachment 70365)
View in context: https://bugs.webkit.org/attachment.cgi?id=70365&action=review

> WebKit/qt/Api/qwebframe.cpp:306
> +    // TextureMapper might use raw OpenGL some other backend. On raster this doesn't have any effect anyway.

raw OpenGL some other... the english sounds a bit strange.

> WebKit/qt/Api/qwebframe.cpp:308
> +    painter->beginNativePainting();
> +    if (rootGraphicsLayer)

do we really need beginNative* if there is no rootGraphicsLayer?

> WebKit/qt/Api/qwebframe.cpp:310
> +    painter->endNativePainting();

I would like a newline after this, as it is a kind of grouping

> WebKit/qt/Api/qwebframe.cpp:360
> +#if USE(ACCELERATED_COMPOSITING) && USE(TEXTURE_MAPPER)

why doesn't texture mapper imply accel. compositing

> WebKit/qt/Api/qwebframe.cpp:361
> +        if (rootGraphicsLayer ) {

remove space after rootGraphicsLayer

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.