[Webkit-unassigned] [Bug 47428] Redo in ReplaceNodeWithSpanCommand is broken

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47428





--- Comment #8 from Darin Adler <darin at apple.com>  2010-10-08 17:55:09 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > The chain of undo steps would have markers to say where an end user command started. This could be another type of UndoStep object. This marker could also contain the user-visible name of the command.
> 
> But that seems to make it hard to support Undo Manager as it's proposed today on whatwg.  See
> http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#undo seem

I think it would be find to have the UndoStep objects grouped into UndoableOperation objects. I just don’t think those should be the same CompositeEditCommand objects we have today. CompositeEditCommand objects have two separate jobs: 1) Doing the edit the first time. 2) Managing the undo process. And the data needed to do the edit the first time has no reason to hang around. I think the code would be easier to read if there was a separation of concerns.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.