[Webkit-unassigned] [Bug 47428] Redo in ReplaceNodeWithSpanCommand is broken

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 17:53:00 PDT 2010


--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-08 17:52:59 PST ---
(In reply to comment #5)
> The chain of undo steps would have markers to say where an end user command started. This could be another type of UndoStep object. This marker could also contain the user-visible name of the command.

But that seems to make it hard to support Undo Manager as it's proposed today on whatwg.  See
http://www.whatwg.org/specs/web-apps/current-work/multipage/dnd.html#undo seem

(In reply to comment #6)
> (From update of attachment 70312 [details])
> Is there any way to prevent us from making this mistake in the future? Are there any other cases of this mistake?

I remember the patch posted to the bug 35281 had a similar mistake.  We can probably prevent the majority of similar mistakes if we can prevent sub classes of CompositeEditCommand to override doUnapply and doReapply.  Can we make CompositeEditCommand's doUnapply and doReapply non-virtual?  Will that prevent sub classes to override them?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list