[Webkit-unassigned] [Bug 44920] Add layout tests for FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44920





--- Comment #21 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-06 15:49:53 PST ---
(In reply to comment #20)
> (From update of attachment 69606 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69606&action=review
> 
> > LayoutTests/fast/filesystem/resources/op-get-entry.js:51
> > +            // FIXME: For now they throw an error because they fail the check for restricted-names: 'a path component should not end with period'.
> 
> Is there a bug logged for that?

Just filed - bug 47309.

> > LayoutTests/fast/filesystem/resources/op-get-parent.js:10
> > +            function(helper) { helper.getParent('/'); },
> 
> How do we verify the results of the getParent?

Currently they don't have explicit assertions.  At least the helper explicitly prints out the parent path so that we can match the actual results with expections (and it's not throwing an error).

> > LayoutTests/fast/filesystem/resources/op-read-directory.js:20
> > +            function(helper) { helper.readDirectory('/'); }
> 
> How are the results of the readDirectory call specified and verified?  Is it just by comparison against the golden results, or is there some way to self-check?

Ditto.  No self-check for now.

> > LayoutTests/fast/filesystem/resources/op-tests-helper.js:15
> > +            return obj;
> 
> Perhaps obj + "" here and below?  Otherwise you haven't done the string conversion.

Will fix.

> > LayoutTests/fast/filesystem/resources/op-tests-helper.js:161
> > +                shouldBe.apply(this, ['this.environment[this.entry.fullPath].fullPath', '"' + entry.fullPath + '"']);
> 
> Could you point me to where this.entry gets set?

Right before the line.
LayoutTests/fast/filesystem/resources/op-tests-helper.js:161
+                 this.entry = entry;

> > LayoutTests/fast/filesystem/resources/op-tests-helper.js:252
> > +        this.getMetadata = function(entry, expectedErrorCode)
> 
> I don't see a test for this.

For getMetadata I wasn't able to make self-assertive one very quickly (and the patch was already big so I stopped adding it).  I'll separately make it.  Filed a new bug 47311.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.