[Webkit-unassigned] [Bug 44920] Add layout tests for FileSystem API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 6 11:37:16 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=44920
--- Comment #20 from Eric U. <ericu at chromium.org> 2010-10-06 11:37:15 PST ---
(From update of attachment 69606)
View in context: https://bugs.webkit.org/attachment.cgi?id=69606&action=review
> LayoutTests/fast/filesystem/resources/op-get-entry.js:51
> + // FIXME: For now they throw an error because they fail the check for restricted-names: 'a path component should not end with period'.
Is there a bug logged for that?
> LayoutTests/fast/filesystem/resources/op-get-parent.js:10
> + function(helper) { helper.getParent('/'); },
How do we verify the results of the getParent?
> LayoutTests/fast/filesystem/resources/op-read-directory.js:20
> + function(helper) { helper.readDirectory('/'); }
How are the results of the readDirectory call specified and verified? Is it just by comparison against the golden results, or is there some way to self-check?
> LayoutTests/fast/filesystem/resources/op-tests-helper.js:15
> + return obj;
Perhaps obj + "" here and below? Otherwise you haven't done the string conversion.
> LayoutTests/fast/filesystem/resources/op-tests-helper.js:161
> + shouldBe.apply(this, ['this.environment[this.entry.fullPath].fullPath', '"' + entry.fullPath + '"']);
Could you point me to where this.entry gets set?
> LayoutTests/fast/filesystem/resources/op-tests-helper.js:252
> + this.getMetadata = function(entry, expectedErrorCode)
I don't see a test for this.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list