[Webkit-unassigned] [Bug 47129] PluginDocumentParser::pluginWidgetFromDocument should look for "embed" element rather than just use the first child

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47129





--- Comment #15 from mitz at webkit.org  2010-10-05 17:36:47 PST ---
(In reply to comment #14)
> (From update of attachment 69856 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69856&action=review
> 
> >> WebCore/html/PluginDocument.h:60
> >> +    RefPtr<Node> m_pluginNode;
> > 
> > Is it okay for a Document to hold a reference to a node like this? Won’t it create a ref cycle and cause a leak?
> 
> Yeah I was concerned about that too. But I was also afraid of holding on to a pointer that was no longer valid. I did some debugging and found that it does indeed cause a ref cycle. I can change it to Node* but I am not sure when to clear this variable. Any suggestions?

I asked and was told that this does not cause a leak.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.