[Webkit-unassigned] [Bug 47129] PluginDocumentParser::pluginWidgetFromDocument should look for "embed" element rather than just use the first child

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47129





--- Comment #16 from sanjeevr at chromium.org  2010-10-05 17:54:46 PST ---
(From update of attachment 69856)
View in context: https://bugs.webkit.org/attachment.cgi?id=69856&action=review

>>>> WebCore/html/PluginDocument.h:60
>>>> +    RefPtr<Node> m_pluginNode;
>>> 
>>> Is it okay for a Document to hold a reference to a node like this? Won’t it create a ref cycle and cause a leak?
>> 
>> Yeah I was concerned about that too. But I was also afraid of holding on to a pointer that was no longer valid. I did some debugging and found that it does indeed cause a ref cycle. I can change it to Node* but I am not sure when to clear this variable. Any suggestions?
> 
> I asked and was told that this does not cause a leak.

Hmm, I did some debugging on Windows Chromium and it did seem to cause a leak. Maybe I missed something. I will debug some more and update this bug. Thanks for the help.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.