[Webkit-unassigned] [Bug 44935] [Qt] Web process crash when pressing modifiers in input field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44935





--- Comment #15 from Balazs Kelemen <kbalazs at webkit.org>  2010-10-05 09:51:13 PST ---
(In reply to comment #14)
> (In reply to comment #13)
> > (From update of attachment 69773 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=69773&action=review
> > 
> > > WebCore/platform/qt/PlatformKeyboardEventQt.cpp:579
> > > +}
> > 
> > We should reorganize the members in the enum to do this test it in O(1). Do you agree?
> 
> It isn't an enum, but defines. 

Doesn't matter.

> We don't need to reorganize it,
> because GCC (and other compilers) generates a jump table
> for this case construction to execute the binary in O(1). ;)

Hm, are you sure? It could do that but I am afraid that the compiler is not so clever (or at least not all the compilers). Do you have an experience about that?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.