[Webkit-unassigned] [Bug 44935] [Qt] Web process crash when pressing modifiers in input field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44935





--- Comment #14 from Csaba Osztrogonac <ossy at webkit.org>  2010-10-05 09:05:58 PST ---
(In reply to comment #13)
> (From update of attachment 69773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69773&action=review
> 
> > WebCore/platform/qt/PlatformKeyboardEventQt.cpp:579
> > +}
> 
> We should reorganize the members in the enum to do this test it in O(1). Do you agree?

It isn't an enum, but defines. We don't need to reorganize it,
because GCC (and other compilers) generates a jump table
for this case construction to execute the binary in O(1). ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.