[Webkit-unassigned] [Bug 46613] [EFL] remove strdup in ewk_setting.cpp using eina_stringshare

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 4 20:05:14 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46613





--- Comment #9 from Ryuan Choi <ryuan.choi at samsung.com>  2010-10-04 20:05:13 PST ---
(In reply to comment #8)
> (From update of attachment 68915 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68915&action=review
> 
> I think it's good, given the issue below is fixed.
> cq- for now.
> 
> > WebKit/efl/ewk/ewk_settings.cpp:164
> > +    return _ewk_icon_database_path;
> 
> HUmn.. a getter like this is ok for web database, but for icon there's a problem: it is not initialized during ewk_init(), so if user calls this getter without previously calling the setter, he will get a NULL instead of the real path.
> 
right, He will get a NULL if it was called before setter.
but we can't get real path before setter because we need to open and enable icon_database using setter.
It's same as current code.

> Since we were previously going through webcore, this was not really an issue. However if we want to make this shortcut now, we need to initialize the icon path in _ewk_init_body() in the same way the web database path is.

Ok, I'll prepare new patch including it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list