[Webkit-unassigned] [Bug 46613] [EFL] remove strdup in ewk_setting.cpp using eina_stringshare

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46613


Lucas De Marchi <demarchi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68915|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #8 from Lucas De Marchi <demarchi at webkit.org>  2010-10-04 09:42:09 PST ---
(From update of attachment 68915)
View in context: https://bugs.webkit.org/attachment.cgi?id=68915&action=review

I think it's good, given the issue below is fixed.
cq- for now.

> WebKit/efl/ewk/ewk_settings.cpp:164
> +    return _ewk_icon_database_path;

HUmn.. a getter like this is ok for web database, but for icon there's a problem: it is not initialized during ewk_init(), so if user calls this getter without previously calling the setter, he will get a NULL instead of the real path.

Since we were previously going through webcore, this was not really an issue. However if we want to make this shortcut now, we need to initialize the icon path in _ewk_init_body() in the same way the web database path is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.