[Webkit-unassigned] [Bug 46505] Add AudioPannerNode files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46505





--- Comment #7 from Kenneth Russell <kbr at google.com>  2010-10-04 16:47:44 PST ---
(From update of attachment 69712)
View in context: https://bugs.webkit.org/attachment.cgi?id=69712&action=review

> WebCore/webaudio/AudioPannerNode.h:96
> +    void setDistanceModel(unsigned model) { m_distanceEffect.setModel(static_cast<DistanceEffect::ModelType>(model), true); }

Per earlier review please change the arguments and return values to unsigned short.

> WebCore/webaudio/AudioPannerNode.idl:42
> +        attribute unsigned long panningModel;

I gather from our offline discussion that the generated glue code doesn't work if these attributes are changed to "unsigned short". It's worth filing a low-priority follow-up bug against the code generators (I'm not sure which would be the best component; "WebCore JavaScript" is a guess) about that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.