[Webkit-unassigned] [Bug 46505] Add AudioPannerNode files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46505





--- Comment #6 from Chris Rogers <crogers at google.com>  2010-10-04 16:31:22 PST ---
(From update of attachment 69522)
View in context: https://bugs.webkit.org/attachment.cgi?id=69522&action=review

>> WebCore/webaudio/AudioPannerNode.cpp:47
>> +static void fixNANS(double &x)
> 
> Naming convention: fixNANS -> fixNANs

FIXED

>> WebCore/webaudio/AudioPannerNode.cpp:95
>> +    AudioBus* destination = output(0)->bus();
> 
> Out of curiosity, why does AudioPannerNode::process not need the same sort of locking as AudioBasicProcessorNode::process? Is it because the number of channels of the input to AudioPannerNode can't change at run time?

Actually the number of channels *can* change, but the panning algorithms do not require any complex re-initialization to handle the different cases since they can simply call different code paths.

>> WebCore/webaudio/AudioPannerNode.cpp:220
>> +    if (elevation < -90.0)
> 
> Presumably this should be "else if".

FIXED

>> WebCore/webaudio/AudioPannerNode.cpp:284
>> +    m_distanceGain->setValue((float)distanceGain);
> 
> Avoid C-style casts.

FIXED

>> WebCore/webaudio/AudioPannerNode.cpp:289
>> +    m_coneGain->setValue((float)coneGain);
> 
> Avoid C-style casts.

FIXED

>> WebCore/webaudio/AudioPannerNode.h:139
>> +    Vector3 m_velocity;
> 
> These should change to use FloatPoint3D, if not now then soon.

added a FIXME

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.