[Webkit-unassigned] [Bug 46527] Add BiquadProcessor files

Mon Oct 4 16:10:44 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=46527

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69707|review?                     |review-
               Flag|                            |

--- Comment #6 from Kenneth Russell <kbr at google.com>  2010-10-04 16:10:44 PST ---
(From update of attachment 69707)
View in context: https://bugs.webkit.org/attachment.cgi?id=69707&action=review

Thanks for addressing the earlier review feedback. One more issue.

> WebCore/webaudio/BiquadProcessor.cpp:51
> +    case HighPass2:

Since it sounds like these share the same coefficients and how the biquad processor is set up (for a low-pass vs. high-pass filter) is handled at a lower level, please fold these two switch arms together and consider adding a comment that they share the same parameter values, only differing in type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.