[Webkit-unassigned] [Bug 46527] Add BiquadProcessor files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46527





--- Comment #5 from Chris Rogers <crogers at google.com>  2010-10-04 16:01:03 PST ---
(From update of attachment 68769)
View in context: https://bugs.webkit.org/attachment.cgi?id=68769&action=review

Also updated LICENSE

>> WebCore/webaudio/BiquadProcessor.cpp:58
>> +        m_parameter3 = AudioParam::create("unused", 0.0, 0.0, 1.0);
> 
> These are the same parameters as LowPass2. Something looks wrong.

This should be OK.  They do have the same parameters.

>> WebCore/webaudio/BiquadProcessor.cpp:68
>> +        m_parameter3 = AudioParam::create("unused", 0.0, 0.0, 1.0);
> 
> These parameters look the same as those for Peaking aside from m_parameter3 being "unused" instead of "gain". I don't know what the right values should be but please double-check both.

Yes, these ones were not quite right.  I've fixed peaking to use the standard three parameters: frequency, gain, Q
and for Allpass: frequency, Q

>> WebCore/webaudio/BiquadProcessor.cpp:73
>> +        m_parameter3 = AudioParam::create("unused", 0.0, 0.0, 1.0);
> 
> Two assignments to m_parameter3 and none to m_parameter2.

FIXED

>> WebCore/webaudio/BiquadProcessor.cpp:78
>> +        m_parameter3 = AudioParam::create("unused", 0.0, 0.0, 1.0);
> 
> Two assignments to m_parameter3 and none to m_parameter2.

FIXED

>> WebCore/webaudio/BiquadProcessor.h:65
>> +    AudioParam& parameter3() { return *m_parameter3; }
> 
> Especially since subclasses take the addresses of these references, I think you should return pointers here. You can indicate in the documentation that the BiquadProcessor owns the storage for the parameters.

FIXED

>> WebCore/webaudio/BiquadProcessor.h:70
>> +    FilterType m_type; // lowpass, highpass, etc.
> 
> As many of these protected fields should be made private as possible. Also, this comment is unnecessary because the FilterType enum is self-documenting.

All made private.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.