[Webkit-unassigned] [Bug 33785] [Gtk] AtkHyperlink needs to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33785





--- Comment #8 from Mario Sanchez Prada <msanchez at igalia.com>  2010-10-01 10:12:48 PST ---
Created an attachment (id=69480)
 --> (https://bugs.webkit.org/attachment.cgi?id=69480)
WIP: Initial version of the patch

After working for these past days on this stuff and trying to figure out how all this stuff works I currently have an initial version of the patch that could one day become the fix for this bug, not only for the use cases mentioned by Joanmarie as "a must" but perhaps even also for the rest of the needs derived of the implementation of this AtkHypetext/AtkHyperlink thing.

Hence, attaching the patch to allow others check it, propose ideas, changes, corrections... and *try it out*, so I could get some feedback that most likely could lead me to change it everything, but that's how software is made, isn't it? :-)

Brief description of the patch, as written in the commit log message:


    Implementing the AtkHypertext/AtkHyperlink stuff in the GTK port

    Done:

     - Implemented AtkHypertext and AtkHyperlinkImpl interfaces in the ATK
       accessibility wrapper (WebKitAccessible).

     - Added new GObject in accessibility/gtk to implement instances of the
       AtkHyperlink abstract class. Called it WebKitAccessibleHyperlink.

     - Added a basic method to provide a lazy mechanism to 'get or create'
       instances of WebKitAccessibleHyperlink for a given AtkObject
       implementing the AtkHyperlinkImpl interface. It's basic, but works
       fine (just a global hashtable and proper methods to deal with it).

     - Implemented all the functions of the AtkHypertext interface and the
       AtkHyperlink abstract class *but* considering only one anchor per
       instance of the AtkHyperlink class for the time being. It should be
       enough at this moment but will need changes for sure if we want to
       support image maps the same way firefox does it, for instance.

     - AtkAction interface not implemented in the WebKitAccessibleHyperlink
       class yet (it should be possible) Pending to check how to do it.

    TODO:

     - Check how to allow more than one anchor per AtkHyperlink

     - Check how to implement AtkAction interface in WebKitAccessibleHyperlink

     - Implement a LayoutTest and/or unit tests to check all this new code

     - Improve the code :-)


Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.