[Webkit-unassigned] [Bug 33785] [Gtk] AtkHyperlink needs to be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33785


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69480|0                           |1
        is obsolete|                            |




--- Comment #9 from Mario Sanchez Prada <msanchez at igalia.com>  2010-10-08 06:12:51 PST ---
Created an attachment (id=70236)
 --> (https://bugs.webkit.org/attachment.cgi?id=70236)
WIP: Patch proposal (unit test pending)

WebKit/gtk/ChangeLogUploading  a new patch with some new stuff from the previous TODO list done.

(In reply to comment #8)
> [...]
>     TODO:
>      - Check how to allow more than one anchor per AtkHyperlink

I talked to Joanie and it seems that, in terms of the screen reader, just having one anchor per AtkHyperlink is enough and correct so, I didn't change this by now as I think the right thing to do would be to ship this patch with this limitation/feature in and, if needed, improve it later on in this aspect as a new bug or something.

>      - Check how to implement AtkAction interface in WebKitAccessibleHyperlink

Implemented AtkAction interface for those WebKitAccessibleHyperlink's where the wrapped AtkObject implements the AtkAction interface, that is, all of them :-) (but a check was added)

>      - Implement a LayoutTest and/or unit tests to check all this new code

Written an unit test to check all the new stuff coming from the AtkHypertext/AtkHyperlink thing. Still pending to add some code to testatk.c to check the correctness of the AtkAction implementation (couldn't do it this week since my devel environment is kind of broken and the unit tests are not working properly now).

>      - Improve the code :-)

Fixed some things here and there, such as how it's made the decision of implement the AtkHyperlinkImpl interface for a AtkObject or how to deal with the special case of list items.

*Not* asking for review yet. Still need to finish some things, such as the unit test for the AtkAction interface

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.