[Webkit-unassigned] [Bug 50061] Move requestGeolocationPermissionForFrame to GeolocationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50061





--- Comment #5 from John Knottenbelt <jknotten at chromium.org>  2010-11-26 04:27:13 PST ---
(From update of attachment 74878)
View in context: https://bugs.webkit.org/attachment.cgi?id=74878&action=review

>> WebCore/page/Chrome.cpp:421
>> +#if !ENABLE(CLIENT_BASED_GEOLOCATION)
> 
> I think we should remove these guards too, for consistency.

Agree.

>> WebCore/platform/mock/GeolocationClientMock.cpp:95
>> +}
> 
> It is certain that all Geolocation objects will call cancel, so the timer is always stopped, before this object is destroyed?

Yes. Perhaps my comment was too terse. when the Frame that hosts the Window that hosts the Navigator object that hosts the Geolocation object is closed, the disconnectFrame() method is called on the Geolocation object which calls cancelPermissionRequest. 

The timers will also be automatically stopped by the Timer destructor on destruction of the containing GeolocationClientMock object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.