[Webkit-unassigned] [Bug 50061] Move requestGeolocationPermissionForFrame to GeolocationClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50061





--- Comment #4 from Steve Block <steveblock at google.com>  2010-11-25 08:03:59 PST ---
(From update of attachment 74878)
View in context: https://bugs.webkit.org/attachment.cgi?id=74878&action=review

> WebCore/page/Chrome.cpp:421
> +#if !ENABLE(CLIENT_BASED_GEOLOCATION)

I think we should remove these guards too, for consistency.

> WebCore/platform/mock/GeolocationClientMock.cpp:95
> +}

It is certain that all Geolocation objects will call cancel, so the timer is always stopped, before this object is destroyed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.