[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49382





--- Comment #37 from Yael <yael.aharon at nokia.com>  2010-11-21 19:25:35 PST ---
(In reply to comment #35)
> (From update of attachment 74412 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74412&action=review
> 
> > WebCore/page/FocusController.cpp:606
> > +void updateFocusCandidateIfNeeded(FocusDirection direction, const IntRect& startingRect, FocusCandidate& candidate, FocusCandidate& closest)
> 
> As far as I can tell, this function does not modify candidate. Can we make this const?
> 
Unfortunately, this causes a chain reaction that does not compile ATM. Mainly because we have 2 copies of the method distanceDataForNode, and that causes the compiler to not be able to convert FocusCandidate to const FocusCandidate.
If you don't mind, I will defer adding the const to https://bugs.webkit.org/show_bug.cgi?id=49442, in which I am removing code that becomes obsolete after this patch. I split it out because this patch is already huge :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.