[Webkit-unassigned] [Bug 49382] Spatial Navigation: issues with the node selection algorithm.

Sun Nov 21 18:34:26 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=49382

--- Comment #36 from Yael <yael.aharon at nokia.com>  2010-11-21 18:34:26 PST ---
(In reply to comment #35)
Thanks for reviewing, Daniel!
I'll update the patch according to your recommendations, but wanted to explain the ASSERT you pointed out.
It is possible to have an iframe without a src attribute, and that will cause us to have a HTMLFrameOwnerElement without contentFrame().

However, I am handling this situation in the second if in updateFocusCandidateIfNeeded.
The ASSERT you saw is there to make sure that in the future, people will not change the code in a way that will cause us to select an empty iframe as the next focus element.
I hope I was able to explain this properly, if it is still not clear, I am happy to continue discussing this, here or on IRC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.