[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #39 from Dirk Schulze <krit at webkit.org>  2010-11-21 08:34:02 PST ---
(In reply to comment #38)
> (In reply to comment #37)
> > (From update of attachment 74492 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=74492&action=review
> > 
> > > WebCore/platform/graphics/cg/GraphicsContextCG.cpp:399
> > > +static Path createConvexPolygonPath(size_t numPoints, const FloatPoint* points)
> > 
> > Path& not Path. Don't copy the created path.
> 
> You can't return a reference here; the Path is being created.

Yes, but maybe if can be a void function and it gets a Path&. Of course it will need the caller functions to create a Path first, but I think it is still better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.