[Webkit-unassigned] [Bug 48516] GraphicsContext: Remove "current path" and have strokePath, fillPath and clipPath take a Path argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48516





--- Comment #40 from Andreas Kling <kling at webkit.org>  2010-11-22 18:38:49 PST ---
(In reply to comment #37)
> > WebCore/platform/graphics/wince/GraphicsContextWinCE.cpp:1386
> > +    // FIXME: Be smarter about this.
> > +    beginPath();
> > +    addPath(path);
> > +
> You use this pattern multiple times, how would you make it smarter? What is wrong with it right now? Just that you use the GC functions instead of platform code? Can you add more details please?

I don't know what the best thing to do on each platform is. It looks like this could be done in nicer ways, but since I can't even build this code, I'd rather not make any larger changes.

> > WebCore/rendering/RenderObject.cpp:958
> > -        graphicsContext->addPath(borderPath);
> > -        graphicsContext->strokePath();
> > +        graphicsContext->strokePath(borderPath);
> 
> hm, Is this correct? We added a Path to the existing one before, with your patch you delete the existing one. Is it possible that an old Path still exist? If not, where is the beginPath()?

I believe that's simply a bug in the current code. Though keep in mind that some GraphicsContext calls clear the path on completion, so a beginPath() may not be necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.