[Webkit-unassigned] [Bug 39908] Reentrant Geolocation tests crash with an assertion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39908





--- Comment #12 from John Knottenbelt <jknotten at chromium.org>  2010-11-18 07:53:57 PST ---
(From update of attachment 74119)
View in context: https://bugs.webkit.org/attachment.cgi?id=74119&action=review

>> WebCore/page/Geolocation.cpp:525
>> +void Geolocation::removeCachedNotifiers(GeoNotifierVector& notifiers, GeoNotifierVector& cached)
> 
> hmm, I was a bit confused with this name and the fact that it has two params, my original thought was that it was removing "cached" from "notifiers"..
> not sure if it'd be any clearer, but perhaps extractNotifiersWithCachedPosition?
> 
> also, both this and copyToSet could be static helper functions rather than regular methods.

Agree with method rename. 
GeoNotifier and GeoNotifierVector are private in Geolocation, which makes it hard to bring these methods out as non-member functions. However, they can be static member functions.

>> WebCore/page/Geolocation.cpp:561
>> +    GeoNotifierVector oneShotsCached;
> 
> as above, perhaps oneShotsWithCachedPosition

Agree.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.