[Webkit-unassigned] [Bug 48986] [GTK] Some key-press events can't be handled by WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48986





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2010-11-16 08:51:33 PST ---
(In reply to comment #3)
> (From update of attachment 73981 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73981&action=review
> 
> Thanks for making this fix!
> 
> > WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:141
> > +static void popupMenuCallback(GtkWidget* widget, EditorClient* client)
> > +{
> > +    g_signal_stop_emission_by_name(widget, "popup-menu");
> > +}
> > +
> > +static void showHelpCallback(GtkWidget* widget, EditorClient* client)
> > +{
> > +    g_signal_stop_emission_by_name(widget, "show-help");
> > +}
> > +
> 
> Since "client" is unused the variable name should be omitted from the argument list.

Right, I copy-pasted from toggleOverwriteCallback, I'll fix that one too.

> Isn't it possible to forward these signals to the WebView? I believe that show-help at least is important for accessibility.

We are stopping the emission of those signals for the GtkTextView, because it's not realized, but not for any other widgets. That's exactly what this patch is fixing, since the signals don't fail they get to the view, see bug #25525.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.