[Webkit-unassigned] [Bug 48986] [GTK] Some key-press events can't be handled by WebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48986


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73981|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-11-16 08:14:36 PST ---
(From update of attachment 73981)
View in context: https://bugs.webkit.org/attachment.cgi?id=73981&action=review

Thanks for making this fix!

> WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:141
> +static void popupMenuCallback(GtkWidget* widget, EditorClient* client)
> +{
> +    g_signal_stop_emission_by_name(widget, "popup-menu");
> +}
> +
> +static void showHelpCallback(GtkWidget* widget, EditorClient* client)
> +{
> +    g_signal_stop_emission_by_name(widget, "show-help");
> +}
> +

Since "client" is unused the variable name should be omitted from the argument list. Isn't it possible to forward these signals to the WebView? I believe that show-help at least is important for accessibility.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.