[Webkit-unassigned] [Bug 49106] Include the FrameView widget of a RenderWidget in the accessibility tree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49106





--- Comment #11 from chris.guillory at google.com  2010-11-15 11:49:17 PST ---
(In reply to comment #10)
> (From update of attachment 73803 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73803&action=review
> 
> > WebCore/accessibility/AccessibilityRenderObject.cpp:416
> > +    // On the mac port this parent logic is in AccessibleObjectWrapper.mm.
> 
> not the right name of the file.
Fixed.

> 
> > WebCore/accessibility/AccessibilityRenderObject.cpp:419
> >      }
> 
> one line else if shouldn't have { }
> 
> > WebCore/accessibility/AccessibilityRenderObject.cpp:1879
> > +#endif
Fixed.

> shouldn't this go into accessibilityIgnoreAttachment() which can be customized per platform?
Seems like the iFrame renderer could always be ignored. It has an unknown role. For now I've moved this logic into AccessibilityObjectChromium.cpp.

> > WebCore/accessibility/AccessibilityRenderObject.cpp:3382
> > +    // for RenderWidget, add frame's content renderer if the widget is a FramwView.
> 
> spelling
Fixed.

> > WebCore/accessibility/AccessibilityRenderObject.cpp:3383
> > +    // on the mac port this children logic is in AccessibleObjectWrapper.mm.
> 
> the file name is AccessibilityObjectWrapper.mm.
> All comments should be full sentences
Fixed capitalization. Is that what you were referring to?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.