[Webkit-unassigned] [Bug 49106] Include the FrameView widget of a RenderWidget in the accessibility tree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49106


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73803|review?                     |review-
               Flag|                            |




--- Comment #10 from chris fleizach <cfleizach at apple.com>  2010-11-15 09:41:02 PST ---
(From update of attachment 73803)
View in context: https://bugs.webkit.org/attachment.cgi?id=73803&action=review

> WebCore/accessibility/AccessibilityRenderObject.cpp:416
> +    // On the mac port this parent logic is in AccessibleObjectWrapper.mm.

not the right name of the file.

> WebCore/accessibility/AccessibilityRenderObject.cpp:419
>      }

one line else if shouldn't have { }

> WebCore/accessibility/AccessibilityRenderObject.cpp:1879
> +#endif

shouldn't this go into accessibilityIgnoreAttachment() which can be customized per platform?

> WebCore/accessibility/AccessibilityRenderObject.cpp:3382
> +    // for RenderWidget, add frame's content renderer if the widget is a FramwView.

spelling

> WebCore/accessibility/AccessibilityRenderObject.cpp:3383
> +    // on the mac port this children logic is in AccessibleObjectWrapper.mm.

the file name is AccessibilityObjectWrapper.mm.
All comments should be full sentences

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.