[Webkit-unassigned] [Bug 49291] Add capability for displaying warnings to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49291


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73784|review?                     |review-
               Flag|                            |




--- Comment #11 from Kent Tamura <tkent at chromium.org>  2010-11-14 18:03:42 PST ---
(From update of attachment 73784)
View in context: https://bugs.webkit.org/attachment.cgi?id=73784&action=review

> WebCore/ChangeLog:3
>  2010-11-12  Ilya Sherman  <isherman at chromium.org>
>  
> +        Reviewed by NOBODY (OOPS!).

The ChangeLog diff should start at the top of ChangeLog.

> WebCore/ChangeLog:12
> +        * platform/chromium/PopupMenuChromium.cpp:
> +        (WebCore::PopupListBox::selectIndex):
> +        * platform/chromium/PopupMenuChromium.h:

The list lacks PopupListBox::getRowFont().
We had better write what we change for each of files/functions as possible.

> WebKit/chromium/ChangeLog:3
>  2010-11-12  Ilya Sherman  <isherman at chromium.org>
>  
> +        Reviewed by NOBODY (OOPS!).

The ChangeLog diff doesn't start at the top of ChangeLog.

> WebKit/chromium/src/AutoFillPopupMenuClient.cpp:254
> +    return m_uniqueIDs[index] == -1;

The rule "uniqueID ==-1 -> warning" looks implicit.  Can we introduce a symbol for this -1?

I also found WebViewClient.h has no explanation of uniqueID.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.