[Webkit-unassigned] [Bug 49291] Add capability for displaying warnings to autofill popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 14 19:38:02 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=49291





--- Comment #12 from Ilya Sherman <isherman at chromium.org>  2010-11-14 19:38:02 PST ---
(From update of attachment 73784)
View in context: https://bugs.webkit.org/attachment.cgi?id=73784&action=review

Thanks as always for the detailed feedback =)

>> WebCore/ChangeLog:3
>> +        Reviewed by NOBODY (OOPS!).
> 
> The ChangeLog diff should start at the top of ChangeLog.

It's the diff tool's fault! =)

But, it should be fixed now, with some other changes interspersed between my two.

>> WebKit/chromium/src/AutoFillPopupMenuClient.cpp:254
>> +    return m_uniqueIDs[index] == -1;
> 
> The rule "uniqueID ==-1 -> warning" looks implicit.  Can we introduce a symbol for this -1?
> 
> I also found WebViewClient.h has no explanation of uniqueID.

Oops, this should actually be uniqueID < 0 -- updated the code to match.

Also added comments to WebView.h and WebViewClient.h to explain the role of the uniqueID.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list