[Webkit-unassigned] [Bug 49291] Add capability for displaying warnings to autofill popup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49291





--- Comment #6 from Ilya Sherman <isherman at chromium.org>  2010-11-11 15:34:54 PST ---
(In reply to comment #5)
> I am not reviewer, but here are my comments:

Thanks for taking a look =)

> > WebCore/platform/chromium/PopupMenuClientChromium.h:31
> > +    virtual bool itemIsWarning(unsigned listIndex) const = 0;
> 
> I think it would have been better to add this to PopupMenuClient (like we did previously for item labels).

For the sake of consistency, we should probably either add this to PopupMenuClient or move the labels out of there.  I don't know the codebase nearly well enough, so I'll defer to others' wisdom here.

> > WebKit/chromium/src/WebViewImpl.cpp:-1946
> > -        m_autoFillPopupClient->setSuggestions(
> 
> Is that call not required anymore?

It's called from within m_autoFillPopupClient->initialize(), so I think this call was redundant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.