[Webkit-unassigned] [Bug 49291] Add capability for displaying warnings to autofill popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 11 15:10:11 PST 2010


--- Comment #5 from Jay Civelli <jcivelli at chromium.org>  2010-11-11 15:10:11 PST ---
I am not reviewer, but here are my comments:

> WebCore/platform/chromium/PopupMenuChromium.cpp:1089
> +      clearSelection();

4 space indent.

> WebCore/platform/chromium/PopupMenuClientChromium.h:31
> +    virtual bool itemIsWarning(unsigned listIndex) const = 0;

I think it would have been better to add this to PopupMenuClient (like we did previously for item labels).

> WebKit/chromium/src/WebViewImpl.cpp:-1946
> -        m_autoFillPopupClient->setSuggestions(

Is that call not required anymore?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list