[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 9 20:08:43 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=49018
--- Comment #19 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-11-09 20:08:43 PST ---
(In reply to comment #18)
> (From update of attachment 73407 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=73407&action=review
>
> > LayoutTests/fast/loader/local-iFrame-directory-from-local.html:8
> > + var localDirectoryLocation = "file:///tmp/LayoutTests/fast/loader/resources/directory";
>
> Sorry. I did not get a chance to give you this feedback before you posted a new patch. Using the "/tmp" directory will not work on Windows machines. If possible this should be changed to a directory relative to the test file.
>
> Additionally the test should use "iframe" instead of "iFrame" to match the rest of the tests in the directory.
All this is base on local-iFrame-source-from-local.html (yes named with a big F) in the same directory. I assumed the test was correct. From this bug point of view, the test reproduce the ASSERT we had, but I'm not a JS expert. If you have a better example to propose I'll take, also if you consider this test wrong, then you should file a bug against those others tests (I think at least two other tests in this directory uses this template).
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list