[Webkit-unassigned] [Bug 49018] [GTK] response.isNull() assert when using directory file URI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 9 17:03:39 PST 2010


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #73407|review?                     |review-
               Flag|                            |

--- Comment #18 from Martin Robinson <mrobinson at webkit.org>  2010-11-09 17:03:40 PST ---
(From update of attachment 73407)
View in context: https://bugs.webkit.org/attachment.cgi?id=73407&action=review

> LayoutTests/fast/loader/local-iFrame-directory-from-local.html:8
> +            var localDirectoryLocation = "file:///tmp/LayoutTests/fast/loader/resources/directory";

Sorry. I did not get a chance to give you this feedback before you posted a new patch. Using the "/tmp" directory will not work on Windows machines. If possible this should be changed to a directory relative to the test file.

Additionally the test should use "iframe" instead of "iFrame" to match the rest of the tests in the directory.

> LayoutTests/fast/loader/local-iFrame-directory-from-local.html:16
> +            var localDirectoryElement = document.createElement("iframe");
> +            localDirectoryElement.setAttribute("id", "myDirectory");
> +            localDirectoryElement.setAttribute("src", localDirectoryLocation);
> +            localDirectoryElement.setAttribute("width", "96%");
> +            localDirectoryElement.setAttribute("height", "70%");

Is it possible to simply include this element in the HTML source instead of adding it dynamically? You might need to use the onload event to run the test at the proper time.

> LayoutTests/fast/loader/local-iFrame-directory-from-local.html:22
> +            var directoryDocument =  document.getElementById("myDirectory").contentDocument;

Is there a guarantee that the load will complete by this point?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list