[Webkit-unassigned] [Bug 49240] Implement formaction, formenctype, formmethod and formtarget attributes for the input tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49240





--- Comment #4 from Kent Tamura <tkent at chromium.org>  2010-11-09 16:08:00 PST ---
(From update of attachment 73354)
View in context: https://bugs.webkit.org/attachment.cgi?id=73354&action=review

> LayoutTests/fast/forms/formaction-attribute-expected.txt:2
> + 
> +This test: PASSED!

The test result should have a test description.

> LayoutTests/fast/forms/formaction-attribute.html:4
> + if (window.layoutTestController)

Indentation looks strange. 1 space?

> LayoutTests/fast/forms/formaction-attribute.html:11
> +ul.document.getElementById('sourceViewDiv').innerHTML=' This test: FAILED 2'
> +}
> +function test2(ul) {
> +ul.document.getElementById('sourceViewDiv').innerHTML=' This test: PASSED!'

No indentation.
No spaces around "="
We had better use functions in fast/js/resources/js-test-pre.js as possible.

> LayoutTests/fast/forms/formaction-attribute.html:27
> +var x=document.getElementsByTagName('input')[0];

Need spaces around "="

> LayoutTests/fast/forms/formmethod-attribute-expected.txt:2
> +
> +Success

The test result should have a test description.

> LayoutTests/fast/forms/formmethod-attribute.html:3
> +<meta http-equiv="content-type" content="text/html; charset=iso-8859-1">

Do we need this line?

> LayoutTests/fast/forms/formmethod-attribute.html:24
> +        if (document.URL.substring(document.URL.indexOf('?')+1, document.URL.length) == "")

style: need spaces around "+"

> LayoutTests/fast/forms/formmethod-attribute.html:25
> +            document.write("<p>Success</p>");

We had better use functions in fast/js/resources/js-test-pre.js as possible.

> LayoutTests/fast/forms/formmethod-attribute.html:35
> +    document.write("<p>This test doesn't work directly from bugzilla, please save it to a local file first.</p>");

We don't need to mention it.

> LayoutTests/fast/forms/formtarget-attribute.html:6
> +            {

Your JavaScript style is inconsistent:

function name() {
  and
function name()
{

Either is ok because we don't have explicit style rules for JavaScript, but you should be consistent.

> LayoutTests/fast/forms/formtarget-attribute.html:10
> +                // Not dumping as text since the DumpRenderTree does not dump the text content of child frames.                

We can access the content of iframe by iframe.contentDocument.  We might need to call layoutTestContentroller.setAllowUniversalAccessFromFileURLs(true).

> LayoutTests/fast/forms/mailto/formenctype-attribute.html:11
> +  if (window.layoutTestController) {

We usually use 4-space indentation.

> WebCore/html/HTMLFormControlElement.cpp:87
> +String HTMLFormControlElement::formAction() const

I don't think we need these access functions.  JavaScript binding doesn't need them because of [Reflect], and HTMLFormElement can access them by getAttribute().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.