[Webkit-unassigned] [Bug 49240] Implement formaction, formenctype, formmethod and formtarget attributes for the input tag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 10 21:20:31 PST 2010


--- Comment #5 from Dai Mikurube <dmikurube at google.com>  2010-11-10 21:20:30 PST ---
(From update of attachment 73354)
View in context: https://bugs.webkit.org/attachment.cgi?id=73354&action=review

>> LayoutTests/fast/forms/formaction-attribute-expected.txt:2
>> +This test: PASSED!
> The test result should have a test description.

Thanks. Made it more descriptive. These four new tests were variations from existing tests with as small changes as possible. For this formaction-attribute.html, from form-action.html.

>> LayoutTests/fast/forms/formtarget-attribute.html:8
>> +                    layoutTestController.waitUntilDone();
> This definitely should be a dumpAsText test.

Thanks. I chose dumpAsText and changed how to verify.

>> WebCore/html/HTMLFormControlElement.cpp:87
>> +String HTMLFormControlElement::formAction() const
> I don't think we need these access functions.  JavaScript binding doesn't need them because of [Reflect], and HTMLFormElement can access them by getAttribute().

Exactly. Removed.

>> WebCore/html/HTMLFormElement.cpp:319
>> +        button = static_cast<HTMLFormControlElement*>(event->target()->toNode());
> This seems like a different method from obtaining the button from above (see firstSuccessfulSubmitButton logic). What's the difference?

firstSuccessfulSubmitButton was different from this "button" object. In cases of my tests, firstSuccessfulSubmitButton was 0, but "button" pointed the button clicked.

>> WebCore/html/HTMLFormElement.cpp:330
>> +    }
> This whole thing looks like it should just live in FormSubmission::create.

I guess it should be handled here for the same reason as copyFrom() below.

>> WebCore/loader/FormSubmission.cpp:121
>> +
> And this becomes unnecessary.

Copying is still required. Values of attributes form* (like formaction) must be parsed by parser methods (like FormSubmission::Attributes::parseAction()). But HTMLFormElement::m_attribute should not be modified.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list